Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] skip metadata check for field equality #2006

Merged
merged 2 commits into from
Mar 13, 2024
Merged

[BUG] skip metadata check for field equality #2006

merged 2 commits into from
Mar 13, 2024

Conversation

samster25
Copy link
Member

@samster25 samster25 commented Mar 13, 2024 •
edited
Loading

  • Ignores metadata when comparing Fields
  • Adds test that reads table written by pyiceberg

closes: #2004

@github-actions github-actions bot added the bug Something isn't working label Mar 13, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.24%. Comparing base (408abdf) to head (0a27bf5).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2006      +/-   ##
==========================================
- Coverage   84.69%   84.24%   -0.45%     
==========================================
  Files          58       59       +1     
  Lines        6369     6404      +35     
==========================================
+ Hits         5394     5395       +1     
- Misses        975     1009      +34

see 3 files with indirect coverage changes

@samster25 samster25 requested a review from jaychia March 13, 2024 04:17
@samster25 samster25 merged commit 3c02ab1 into main Mar 13, 2024
31 checks passed
@samster25 samster25 deleted the sammy/skip-metadata-check-on-fields branch March 13, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaychia jaychia Awaiting requested review from jaychia

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with read_iceberg function when using an s3 warehouse location
1 participant
@samster25